ci(workflow): drop hardcoded exec-maven-plugin:3.5.0 (PR-7.1)#80
Merged
Conversation
3 tasks
…teps
The three CI benchmark steps (perf smoke, full benchmark, benchmark diff)
invoked org.codehaus.mojo:exec-maven-plugin:3.5.0:java directly, while
benchmarks/pom.xml already declared exec-maven-plugin at 3.6.3 for local
runs — a silent version split between CI and local invocations.
Switching CI to exec:java resolves the plugin through benchmarks/pom.xml's
build/plugins declaration (3.6.3), so there is only one version to bump.
Reproduced locally:
./mvnw -B -ntp -f benchmarks/pom.xml -DskipTests exec:java \
-Dexec.mainClass=com.demcha.compose.CurrentSpeedBenchmark \
-Dgraphcompose.benchmark.profile=smoke
→ Performance gate passed for profile smoke (BUILD SUCCESS, 15s)
Part of v1.6.5 publish hygiene (PR-7.1).
8b83b6b to
d195a91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
org.codehaus.mojo:exec-maven-plugin:3.5.0:javainvocations in .github/workflows/ci.yml withexec:java, so the CI workflow resolves the plugin throughbenchmarks/pom.xml'sbuild/pluginsdeclaration (3.6.3).v1.6.5 — PlannedCHANGELOG section.Why
benchmarks/pom.xml:134-138already pinsexec-maven-plugin:3.6.3forlocal benchmark runs, but CI bypassed that pin and invoked
3.5.0directly — a silent version split between CI and local invocations
that grew the surface area to keep aligned. Using
exec:javaletsMaven resolve the plugin through the module POM, so there is only one
version to bump going forward.
This is the third of three short branches unblocking the v1.6.5 cut
(alongside PR-7.2 #79
chore/byte-buddy-test-scopeand PR-7.3fix/pagebackgrounds-empty-and-row-weights). Tracked in the privaterelease-readiness taskboard.
Verification
The exact CI command was reproduced locally on JDK 17:
→
Performance gate passed for profile smoke· BUILD SUCCESS · ~15 s.The full and diff invocations follow the same pattern (only the
mainClass / profile /
enforceGateflags differ), so plugin resolutionis identical.
Test plan
exec:javainvocation